Comments on: AJAX file upload progress for Java using commons fileupload and prototype

By: Driss

Driss — Fri, 01 Jan 2010 21:12:02 +0000

It's still accurate, efficient (very fast) and it gives more control on the flow than [

ProgressListener

] provided by the

commons-fileupload

;
many thanks for sharing Carson +++

It can handle also multiple files uploaded at once
(but the better is to generate dynamically new forms in the Javascript side as needed and handling the upload in Threads)

I simply handled some javascript cases :
-/ In [UploadServlet.java], escaping character "'" within the server's message returned by sendCompleteResponse() :

window.parent.killUpdate('" + message.replace("'", "\'") + "');

In the client side, testing [updater] before stop it in [function killUpdate(message) :

if(updater != null){
updater.stop();
}

All the best !

By: Debabrata Biswas

Debabrata Biswas — Tue, 08 Dec 2009 11:02:53 +0000

I used your source code,it runs in local computer fine,showing percentage bar.But when i put this code in live server.it wont run mean progress bar not showing…I add every things whatever i used in local computer.Showing UploadMonotor not defined.I add DWR jar2.5,DWR.XML that create UploadMonitor.js.And import classes that contains UploadMonitor class.Please If you can look around for this your help is much appreciated and very needful to me.

By: Sonia Pandit

Sonia Pandit — Tue, 01 Dec 2009 18:59:34 +0000

It works nicely, but I have a lot of red markups in eclipse for the prototype.js file.
Sorry I don't have too much experience in javascript. I also need to upload multiple files. How do I modify it for multiple file upload and where are the files being uploaded to?

Thanks,

Sonia

By: tmax

tmax — Tue, 11 Aug 2009 12:22:39 +0000

Hi Carson,

Nice example you have provided in source code.

I have came across a problem in your source code.

When file upload completes and response comes to the html page, it is not able to call the javascript function "killUpdate". That results in the non stop update cycle.

I have tried with eval() but no success. If you can look around for this your help is much appreciated.

thanks

By: Dan

Dan — Tue, 06 May 2008 15:34:56 +0000

One issue I ran into with this code was adding non-file form fields along with the file field. For example, I added a description field before my file upload field. This caused the bytes read to be set to the total size as soon as the file upload began. Then my progress bar would go to 200%. Here is my fix, I'm open to better solutions if any.

Inside MonitoredDiskFileItem.java:

public OutputStream getOutputStream() throws IOException {
if( mos == null ) {
// Create a new MonitoredOutputStream.
this.mos = new MonitoredOutputStream(super.getOutputStream(), listener);

// Reset the bytes of the file upload listener.
( (FileUploadListener ) listener ).getFileUploadStats().setBytesRead(0);
}

return this.mos;
}

By: Matt

Matt — Thu, 13 Sep 2007 18:58:19 +0000

Very nice. Took me a moment to figure out that the sample code is NOT what you were going over in the text of the article.

By: ss

ss — Sat, 08 Sep 2007 06:54:14 +0000

I think i will use dojo insted of prototype.

By: ss

ss — Sat, 08 Sep 2007 06:52:03 +0000

Excellent
This is what I was looking for.

By: Stephen More

Stephen More — Wed, 28 Feb 2007 18:15:50 +0000

commons-fileupload version 1.2 now has support for progress listeners:
upload.setProgressListener(progressListener);

It also supports Streaming so the upload can go straight into a database.

Perhaps you can provide a new example…the code has been simplified.